Repository navigation
Fix spurious TCP resets when initiating TLS connection closure - #898
Merged
Merged
Conversation
When an HTTP/1.1 response contains `Connection: close`, the async client begins a graceful TLS shutdown. This causes `SSLIOSession.isOpen()` to immediately start returning `false`, so at the completion of the HTTP exchange when `AsyncProtocolExec` calls `isEndpointConnected()`, the `InternalConnectionEndpoint.isConnected()` method sees that the pool entry's underlying connection is reporting `!isOpen()` and calls `poolEntry.discardConnection(CloseMode.IMMEDIATE)`, which sends a TCP reset to the server. This commit changes that `discardConnection` call site to use `CloseMode.GRACEFUL`, and also provides a reproducer and integration test demonstrating the problem.
ok2c
approved these changes
Oct 14, 2026
Member
|
Please also cheery-pick to |
Contributor
Author
|
Cherry-picked to 5.6.x as 54c5ad8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an HTTP/1.1 response contains
Connection: close, the async client begins a graceful TLS shutdown. This causesSSLIOSession.isOpen()to immediately start returningfalse, so at the completion of the HTTP exchange whenAsyncProtocolExeccallsisEndpointConnected(), theInternalConnectionEndpoint.isConnected()method sees that the pool entry's underlying connection is reporting!isOpen()and callspoolEntry.discardConnection(CloseMode.IMMEDIATE), which sends a TCP reset to the server.This commit changes that
discardConnectioncall site to useCloseMode.GRACEFUL, and also provides a reproducer and integration test demonstrating the problem.